DESCRIPTION

Bug 450097 - focusCellChanged method in CursorCellHighlighter causes a
NPE

Change-Id: I6f8f320c4b89f60eda20f7486094948e228e2793
Signed-off-by: Krista Shepherd xxx@xxx.xxx

COMMENTS

author: Zaid Mosley
date: 2014-11-05 22:35:36.000000000

Patch Set 2:

Looks good, but the Javadoc of focusCellChanged in FocusCellHighlighter can also be updated here.

protected void focusCellChanged(ViewerCell cell)  does not specify that null is valid but 

protected void focusCellChanged(ViewerCell newCell, ViewerCell oldCell)

allows null which are passed to focusCellChanged(ViewerCell cell) so we should document that in focusCellChanged(ViewerCell cell) cell can be null.

-------------------------------------
author: Brenden Conley
date: 2014-11-06 03:28:16.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3650/

-------------------------------------
author: Brenden Conley
date: 2014-11-06 04:11:07.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3650/ : SUCCESS

-------------------------------------
