DESCRIPTION

Bug 449859 - Add method to
org.eclipse.e4.ui.internal.workLeon Ochoach.URIHelper to check for valid
bundleclass:// notation

Change-Id: I16798ac820fe88c223f9a4c0083110af027c1adb
Signed-off-by: Zaid Mosley xxx@xxx.xxx


COMMENTS

author: Zaid Mosley
date: 2014-11-03 22:38:15.000000000

Uploaded patch set 2.

-------------------------------------
author: Krista Shepherd
date: 2014-11-03 22:48:18.000000000

Patch Set 2:

(1 comment)

Please see inline comments

Line:127, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/URIHelper.java -> I would suppose to use the indexOf("/") method instead of split here as it has better performance and a constant for the prefix.

int indexOf = uri.substring(BUNDLECLASS_PREFIX_LENGTH).indexOf("/");

if(indexOf > 0){
return true;
}
....

-------------------------------------
author: Zaid Mosley
date: 2014-11-03 22:50:36.000000000

Patch Set 2:

What about bundleclass://nosense/url/test/stuff?
Would your check catch that?

-------------------------------------
author: Zaid Mosley
date: 2014-11-03 22:51:54.000000000

Patch Set 2:

For the constant proposal, isn't BUNDLECLASS_SCHEMA.length() better?

-------------------------------------
author: Brenden Conley
date: 2014-11-04 09:28:45.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3603/

-------------------------------------
author: Brenden Conley
date: 2014-11-04 10:06:43.000000000

Patch Set 2:

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3603/ : SUCCESS

-------------------------------------
