DESCRIPTION

[390348] Move projects from working set to the other with DND

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=390348
Change-Id: Ia8ca4eefc76056c2f349488d98b8faf17db9c13a
Signed-off-by: Isis Velasquez xxx@xxx.xxx


COMMENTS

author: Isis Velasquez
date: 2015-03-25 09:50:05.000000000

Uploaded patch set 10.

-------------------------------------
author: Brenden Conley
date: 2015-03-25 10:04:40.000000000

Patch Set 10:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5162/

-------------------------------------
author: Brenden Conley
date: 2015-03-25 10:23:24.000000000

Patch Set 10: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5162/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2015-04-01 17:47:15.000000000

Patch Set 10:

(8 comments)

I'll push up a revised patch with a few tweaks.

Line:42, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/workingsets/ProjectInWorkingSetDropAdapterAssistant.java -> Don't need these comments any more

Line:59, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/workingsets/ProjectInWorkingSetDropAdapterAssistant.java -> Since we want a yes/no, there's little point to accumulating the objects

Line:67, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/workingsets/ProjectInWorkingSetDropAdapterAssistant.java -> Unnecessary cast

Line:83, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/workingsets/ProjectInWorkingSetDropAdapterAssistant.java -> Don't need these comments any more

Line:87, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/workingsets/ProjectInWorkingSetDropAdapterAssistant.java -> I love Smalltalk but use consistent naming as per the validateDrop()

Line:94, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/workingsets/ProjectInWorkingSetDropAdapterAssistant.java -> Need to check project != null.  And this move will fail if the CN is not showing an Adaptable in the top level

Line:95, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/workingsets/ProjectInWorkingSetDropAdapterAssistant.java -> Unnecessary cast

Line:137, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/workingsets/ProjectInWorkingSetDropAdapterAssistant.java -> Not a particularly useful comment :-)

-------------------------------------
