DESCRIPTION

Bug 446652 - org.eclipse.e4.ui.dialogs plug-in should contain a new
implementation of the ListSelectionDialog

Change-Id: I312cb8c4a9c7617ac4d534fa0049048577512f21
Signed-off-by: Krista Shepherd xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2015-04-14 23:08:21.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5378/

-------------------------------------
author: Brenden Conley
date: 2015-04-14 23:38:15.000000000

Patch Set 6: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5378/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2015-08-28 14:36:31.000000000

Patch Set 6:

(3 comments)

Line:52, bundles/org.eclipse.e4.ui.dialogs/src/org/eclipse/e4/ui/dialogs/ListSelectionDialog.java -> I would put every parameter in its own line, like in the old ListSelectionDialog

Line:53, bundles/org.eclipse.e4.ui.dialogs/src/org/eclipse/e4/ui/dialogs/ListSelectionDialog.java -> I would avoid using org.eclipse.ui API in the example. Maybe better to use ArrayContentProvider and LabelProvider?

Line:63, bundles/org.eclipse.e4.ui.dialogs/src/org/eclipse/e4/ui/dialogs/ListSelectionDialog.java -> Add Description here of the type, see IAdapterFactory.getAdapter for an example

-------------------------------------
