DESCRIPTION

Bug 446652 - org.eclipse.e4.ui.dialogs plug-in should contain a new
implementation of the ListSelectionDialog

Change-Id: I312cb8c4a9c7617ac4d534fa0049048577512f21
Signed-off-by: Krista Shepherd xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2014-10-20 21:18:40.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3418/

-------------------------------------
author: Brenden Conley
date: 2014-10-20 21:43:50.000000000

Patch Set 2: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3418/ : FAILURE

-------------------------------------
author: Zaid Mosley
date: 2014-10-21 14:39:18.000000000

Patch Set 2:

(1 comment)

Line:132, bundles/org.eclipse.e4.ui.dialogs/src/org/eclipse/e4/ui/dialogs/ListSelectionDialog.java -> Isn't that the <T> type. Why specify it again?

-------------------------------------
author: Krista Shepherd
date: 2014-10-21 14:44:21.000000000

Patch Set 2:

(1 comment)

Line:132, bundles/org.eclipse.e4.ui.dialogs/src/org/eclipse/e4/ui/dialogs/ListSelectionDialog.java -> Yes it is, but here I need the class instance for Databinding and <T> won't be available at runtime in order to use it for the IObservable factories like ViewerProperties.checkedElements(elementType).observe(viewer);

-------------------------------------
author: Zaid Mosley
date: 2014-10-21 14:52:18.000000000

Patch Set 3: Patch Set 2 was rebased

-------------------------------------
