DESCRIPTION

Bug 446652 - org.eclipse.e4.ui.dialogs plug-in should contain a new
implementation of the ListSelectionDialog

Change-Id: I312cb8c4a9c7617ac4d534fa0049048577512f21
Signed-off-by: Krista Shepherd xxx@xxx.xxx

COMMENTS

author: Krista Shepherd
date: 2014-10-10 13:23:04.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-10-10 15:13:46.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3369/

-------------------------------------
author: Brenden Conley
date: 2014-10-10 15:33:39.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3369/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-10-20 20:45:50.000000000

Patch Set 1:

(4 comments)

Line:64, bundles/org.eclipse.e4.ui.dialogs/src/org/eclipse/e4/ui/dialogs/ListSelectionDialog.java -> Why not use generics for the input

Line:85, bundles/org.eclipse.e4.ui.dialogs/src/org/eclipse/e4/ui/dialogs/ListSelectionDialog.java -> I don't see the value of these static create methods. They seem the handle special cases.

Line:142, bundles/org.eclipse.e4.ui.dialogs/src/org/eclipse/e4/ui/dialogs/ListSelectionDialog.java -> Why not use generics for the Input?

Line:200, bundles/org.eclipse.e4.ui.dialogs/src/org/eclipse/e4/ui/dialogs/ListSelectionDialog.java xxx@xxx.xxx does not add value here and is not required for private methods.

-------------------------------------
author: Zaid Mosley
date: 2014-10-20 20:51:50.000000000

Patch Set 2: Patch Set 1 was rebased

-------------------------------------
