DESCRIPTION

Bug 444070 - Reduce warning messages in the Platform.ui repository

Removed raw types and fixed javadoc comments from
org.eclipse.ui.tests.harness

Change-Id: I4fa4e01832cd80c477d18292d99791e41e569ee5
Signed-off-by: Jessica Roy xxx@xxx.xxx

COMMENTS

author: Jessica Roy
date: 2014-11-02 06:03:45.000000000

Uploaded patch set 9.

-------------------------------------
author: Jessica Roy
date: 2014-11-02 06:06:46.000000000

Patch Set 9:

Regarding the TestEditorHelper, I don`t see an easier way to change that different from the toArray method. Observe that findFiles can work with an IFile or IContainer, therefore, passing List<IFile> is not allowed. Also, I don't think we can do much if we change the findFiles to receiver a List<? extends IResource>. Do you have any think in mind Nevaeh Wu?

-------------------------------------
author: Brenden Conley
date: 2014-11-02 07:50:47.000000000

Patch Set 9:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3574/

-------------------------------------
author: Brenden Conley
date: 2014-11-02 08:26:54.000000000

Patch Set 9: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/3574/ : SUCCESS

-------------------------------------
author: Krista Shepherd
date: 2014-11-02 16:22:25.000000000

Patch Set 9:

Concerning the EditorTestHelper it should look like the following, because adding an IResource to the list, which is not an IFile will cause a ClassCastException later on with the files.toArray(new IFile[files.size()]); method invocation.

	public static IFile[] findFiles(IResource resource) throws CoreException {
		List<IFile> files= new ArrayList<IFile>();
		findFiles(resource, files);
		return files.toArray(new IFile[files.size()]);
	}

	private static void findFiles(IResource resource, List<IFile> files) throws CoreException {
		if (resource instanceof IFile) {
			files.add((IFile)resource);
			return;
		}

-------------------------------------
author: Zaid Mosley
date: 2014-11-05 06:56:33.000000000

Patch Set 9: Code-Review-1

Jeanderson, can you please look at Nevaeh Wus suggestions?

-------------------------------------
author: Jessica Roy
date: 2014-11-06 00:20:10.000000000

Patch Set 10: Patch Set 9 was rebased

-------------------------------------
