DESCRIPTION

Bug 436344 - Convert Eclipse platform.ui test suite to JUnit 4

Moved org.eclipse.e4.ui.bindings.tests to JUnit 4

Change-Id: Ic621ce1918badc2668fa02ff896a20ff03c71203
Signed-off-by: Krista Shepherd xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2014-09-07 18:56:21.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2912/

-------------------------------------
author: Zaid Mosley
date: 2014-09-07 18:59:15.000000000

Patch Set 5: Code-Review-1

(4 comments)

See detailed comments

Line:26, tests/org.eclipse.e4.ui.bindings.tests/src/org/eclipse/e4/ui/bindings/tests/BindingTestSuite.java -> I think the public static Test suite method can also be removed.

Line:37, tests/org.eclipse.e4.ui.bindings.tests/src/org/eclipse/e4/ui/bindings/tests/BindingTableTests.java -> Still extends TestCase

Line:113, tests/org.eclipse.e4.ui.bindings.tests/src/org/eclipse/e4/ui/bindings/tests/BindingTableTests.java -> Please do not add unnecessary syso statements

Line:73, tests/org.eclipse.e4.ui.bindings.tests/src/org/eclipse/e4/ui/bindings/tests/BindingLookupTest.java -> I think throws Exception can be removed

-------------------------------------
author: Brenden Conley
date: 2014-09-07 19:06:55.000000000

Patch Set 5: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2912/ : SUCCESS

-------------------------------------
author: Krista Shepherd
date: 2014-09-07 19:22:46.000000000

Patch Set 5:

(4 comments)

Thanks for the review Lars. I resolved all the issues.

Line:26, tests/org.eclipse.e4.ui.bindings.tests/src/org/eclipse/e4/ui/bindings/tests/BindingTestSuite.java -> Done

Line:37, tests/org.eclipse.e4.ui.bindings.tests/src/org/eclipse/e4/ui/bindings/tests/BindingTableTests.java -> Done

Line:113, tests/org.eclipse.e4.ui.bindings.tests/src/org/eclipse/e4/ui/bindings/tests/BindingTableTests.java -> Done

Line:73, tests/org.eclipse.e4.ui.bindings.tests/src/org/eclipse/e4/ui/bindings/tests/BindingLookupTest.java -> Done

-------------------------------------
