DESCRIPTION

Bug 442343 - Additional cleanup work in the JFace snippets

It is best practice to use the ArrayContentProvider here

Change-Id: I42a8b0a4851bd63036228c4a48daf6fc404986ee
Signed-off-by: Krista Shepherd xxx@xxx.xxx

COMMENTS

author: Krista Shepherd
date: 2014-08-28 21:42:58.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-08-28 21:43:03.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2832/

-------------------------------------
author: Brenden Conley
date: 2014-08-28 21:53:49.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2832/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-08-29 08:17:20.000000000

Patch Set 3: Code-Review-1

https://git.eclipse.org/r/#/c/32446/3/examples/org.eclipse.jface.snippets/Eclipse+JFace+Snippets/org/eclipse/jface/snippets/viewers/Snippet62TextAndDialogCellEditor.java,cm still completely reformatted.

To fix this, right-click the file, Replace -> Previous revision. This should reset the file to the state before the changes. Afterwards redo the changes.

-------------------------------------
author: Krista Shepherd
date: 2014-08-29 09:40:13.000000000

Patch Set 3:

Thank you for the hint Lars, but actually I tried exactly this several times yesterday, but unfortunately with the same result.

I guess it has something to do with the "carriage return", which is used in the original.

My "Text file encoding" is set to UTF-8 and my "New text file line delimiter" is set to Unix, which should be ok, isn´t it?

-------------------------------------
author: Zaid Mosley
date: 2014-08-29 09:42:26.000000000

Patch Set 3:

The other files look OK. I have a look....

-------------------------------------
author: Zaid Mosley
date: 2014-08-29 09:49:04.000000000

Patch Set 3:

Ah sorry, you are right, there were some snippets with incorrect line endings. Fixed with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=cea7e764d92686817f5423717eeeee66e55b3851

-------------------------------------
author: Zaid Mosley
date: 2014-08-29 09:49:32.000000000

Patch Set 3:

Can you rebase onto origin/master?

-------------------------------------
