DESCRIPTION

Bug 442343 - Additional cleanup work in the JFace snippets

It is best practice to use the ArrayContentProvider here

Change-Id: I42a8b0a4851bd63036228c4a48daf6fc404986ee
Signed-off-by: Krista Shepherd xxx@xxx.xxx

COMMENTS

author: Krista Shepherd
date: 2014-08-28 00:56:14.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-08-28 00:56:20.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2807/

-------------------------------------
author: Brenden Conley
date: 2014-08-28 01:07:34.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2807/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-08-28 07:32:44.000000000

Patch Set 1:

(2 comments)

Thanks looks, good. Minor suggestions included

Line:32, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/layout/Snippet016TableLayout.java -> Can you also update the description?

Line:35, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/layout/Snippet016TableLayout.java -> Can be removed, the since tag is used for API

-------------------------------------
author: Krista Shepherd
date: 2014-08-28 11:33:43.000000000

Patch Set 1:

(2 comments)

Thanks Lars. I just implemented your proposals in the comments.

Line:32, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/layout/Snippet016TableLayout.java -> Done

Line:35, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/layout/Snippet016TableLayout.java -> Done

-------------------------------------
