DESCRIPTION

Bug 361731 - Set size constraints on children of PartSashContainer

Change-Id: I4c7ca0a9765f73d0c9123a4eab9042b79a774d65
Signed-off-by: Arturo Copeland xxx@xxx.xxx

COMMENTS

author: Arturo Copeland
date: 2014-09-08 17:58:07.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2014-09-08 17:58:12.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2921/

-------------------------------------
author: Arturo Copeland
date: 2014-09-08 17:59:22.000000000

Patch Set 5:

added null check - needed when all parts are dragged into single stack, then a part is moved out, creating a new stack.

-------------------------------------
author: Brenden Conley
date: 2014-09-08 18:11:14.000000000

Patch Set 5: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2921/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-09-09 14:48:15.000000000

Patch Set 5:

(4 comments)

I did a first quick pass. Please remove the commented code, this make the review unnecessary hard.

Line:24, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/SashUtil.java -> Is this used outside the SashRenderer? If not integrate it into the renderer and make its methods private

Line:82, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/PartSizeInfo.java -> Long code comments should be avoided

Line:86, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/PartSizeInfo.java -> Commented code

Line:285, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/SashLayout.java -> Remove commented code

-------------------------------------
author: Arturo Copeland
date: 2014-09-09 16:53:38.000000000

Patch Set 5:

(4 comments)

Comments (old code) were left in while waiting for feedback from comment on bug related to removing previously implemented features.  They were never intended to be merged.

Line:24, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/SashUtil.java -> This code is written to be a common library used and tested by other classes besides the SWT renderer.

Line:82, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/PartSizeInfo.java -> removed

Line:86, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/PartSizeInfo.java -> removed

Line:285, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/SashLayout.java -> removed

-------------------------------------
