DESCRIPTION

Bug 442350 - Project settings for org.eclipse.ui.monitoring and
org.eclipse.ui.monitoring.tests

Change-Id: I65b35c9899dfdd5723c912169b99b6ab19fb68e4
Signed-off-by: Zaid Mosley xxx@xxx.xxx

COMMENTS

author: Zaid Mosley
date: 2014-08-22 09:49:17.000000000

Uploaded patch set 1.

-------------------------------------
author: Zaid Mosley
date: 2014-08-22 09:49:47.000000000

Patch Set 1:

Sergey, please review

-------------------------------------
author: Brenden Conley
date: 2014-08-22 10:11:26.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2787/

-------------------------------------
author: Brenden Conley
date: 2014-08-22 10:21:08.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2787/ : SUCCESS

-------------------------------------
author: Brock Pruitt
date: 2014-08-22 18:48:25.000000000

Patch Set 1:

(1 comment)

See a inline comment.

Line:21, bundles/org.eclipse.ui.monitoring/.settings/org.eclipse.jdt.ui.prefs -> I don't think auto-formatting of changed lines should be turned on since JDT formatter is very buggy (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=303519).

-------------------------------------
author: Zaid Mosley
date: 2014-08-25 18:09:55.000000000

Patch Set 1:

Is it really that bad? We use it for most other plug-ins in platform.ui and it seems to work fine.

-------------------------------------
author: Sebastian Porter
date: 2014-08-25 18:12:50.000000000

Patch Set 1: Code-Review-1

> Is it really that bad? We use it for most other plug-ins in platform.ui and it seems to work fine.

Standard inside UI wins and hence we'll go with that.

-------------------------------------
author: Sebastian Porter
date: 2014-08-25 18:12:59.000000000

Patch Set 1: -Code-Review

-------------------------------------
author: Zaid Mosley
date: 2014-08-25 18:30:17.000000000

Patch Set 2: Patch Set 1 was rebased

-------------------------------------
