DESCRIPTION

Bug 441329 - Add option to disable workspace version check

Change-Id: I01265bf5fa199461d1a63184ebe1f0cc2384ebcf
Signed-off-by: Braedon Velazquez xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2014-08-13 19:04:31.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2662/

-------------------------------------
author: Brenden Conley
date: 2014-08-13 19:13:58.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2662/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-08-13 19:15:36.000000000

Patch Set 2:

(4 comments)

Looks good, some minor suggestions inlined. In general I think having two preference is a bit overkill. I suggest to have only one preference and use it both for down and upgrades.

Line:411, bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEApplication.java -> Hard for me to decode, maybe use: "warnUserAboutWorkspaceChanges". A bit long but more descriptive

Line:980, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/messages.properties -> Maybe better: Do not show again information about Workspace incompabilities.

Line:127, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEInternalPreferences.java -> While you are here, why not delete whitespace in this line?

Line:137, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEInternalPreferences.java -> While you are here, why not delete whitespace in this line?

-------------------------------------
author: Braedon Velazquez
date: 2014-08-14 11:58:06.000000000

Patch Set 2:

(4 comments)

Line:411, bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEApplication.java -> Done

Line:980, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/messages.properties -> Done

Line:127, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEInternalPreferences.java -> Done

Line:137, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEInternalPreferences.java -> Done

-------------------------------------
