DESCRIPTION

Bug 441015 -Added event loop monitoring plugin

(with corresponding feature and tests)

Change-Id: Ie98bbdc53c35aecbb9d56e73398c041402361314
Signed-off-by: Wesley Lawson <Carter xxx@xxx.xxx


COMMENTS

author: Wesley Lawson
date: 2014-08-05 19:42:34.000000000

Uploaded patch set 12.

-------------------------------------
author: Brenden Conley
date: 2014-08-05 19:50:57.000000000

Patch Set 12:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2612/

-------------------------------------
author: Zaid Mosley
date: 2014-08-05 19:57:33.000000000

Patch Set 12:

(1 comment)

Can you add README.md files to the plug-ins describing their purpose and there usage?

Line:759, features/org.eclipse.e4.rcp/feature.xml -> We don't want to have the monitoring plug-in as part of RCP. I think the right place to add it, would be /git/eclipse.platform.releng/features/org.eclipse.sdk/feature.xml This is a different repo.

-------------------------------------
author: Brenden Conley
date: 2014-08-05 20:00:21.000000000

Patch Set 12: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2612/ : SUCCESS

-------------------------------------
author: Brock Pruitt
date: 2014-08-05 20:05:06.000000000

Patch Set 12:

(4 comments)

Line:26, bundles/org.eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/FilterHandler.java -> A space is missing before {

Line:37, bundles/org.eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/FilterHandler.java -> Rewrite as:
int c = methodName.compareTo(other.methodName);
if (c != 0)
  return c;
return className.compareTo(other.className);

Line:54, bundles/org.eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/FilterHandler.java -> Protect against period < 0, which may happen if the dot is not found.

Line:95, bundles/org.eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/FilterHandler.java -> Rewrite as:
String methodName = element.getMethodName();
String className = element.getClassName();
int low= 0;
int high= filters.length;
while (low < high) {
  int mid= (low + high) >>> 1;
  Filter filter = filters[mid];
  int c = methodName.compareTo(filter.methodName);
  if (c == 0)
    c = className.compareTo(filter.className);
  if (c == 0) {
    return true;
  } else if (c < 0) {
    high = mid;
  } else {
    low = mid + 1;
  }
}

-------------------------------------
author: Wesley Lawson
date: 2014-08-05 20:42:51.000000000

Patch Set 12:

(5 comments)

Line:26, bundles/org.eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/FilterHandler.java -> Done

Line:37, bundles/org.eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/FilterHandler.java -> Done

Line:54, bundles/org.eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/FilterHandler.java -> Done

Line:95, bundles/org.eclipse.ui.monitoring/src/org/eclipse/ui/internal/monitoring/FilterHandler.java -> Done

Line:759, features/org.eclipse.e4.rcp/feature.xml -> Done

-------------------------------------
