DESCRIPTION

Bug 117746 - [EditorMgmt] Editors should be able to treat large files
specially


Change-Id: I0bb10dd51a3a8a92eaed7f904b2c40751352b074


COMMENTS

author: Slade Moran
date: 2014-07-23 17:43:17.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-07-23 18:16:41.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2493/

-------------------------------------
author: Brenden Conley
date: 2014-07-23 18:25:36.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2493/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-07-23 18:31:44.000000000

Patch Set 1:

(1 comment)

Line:57, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/dialogs/EditorSelectionDialog.java -> Are you still using a release before Luna? If yes, please upgrade to Luna. With Luna JDT does not add this whitespace anymore.

-------------------------------------
author: Slade Moran
date: 2014-07-23 18:35:51.000000000

Patch Set 1:

(1 comment)

Line:57, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/dialogs/EditorSelectionDialog.java -> I'm using early Mars, 4.5.0.I20140722-0800

-------------------------------------
author: Zaid Mosley
date: 2014-07-23 19:15:09.000000000

Patch Set 1:

(4 comments)

Maybe you copied existing Javadoc? In 4.4 JDT should not add them automatically, this was a JDT bug

Line:273, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/IPreferenceConstants.java -> Please remove

Line:57, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/dialogs/EditorSelectionDialog.java -> Please remove

Line:57, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/dialogs/EditorSelectionDialog.java -> Done

Line:81, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/dialogs/EditorSelectionDialog.java -> Please remove

-------------------------------------
author: Slade Moran
date: 2014-07-23 19:24:40.000000000

Patch Set 1:

I won't be coming back to this patch unless there's a functional problem that someone else can't solve (no time).  If I do, I'll try to remember to remove those.

-------------------------------------
author: Zaid Mosley
date: 2014-07-23 19:36:16.000000000

Patch Set 1:

Makes sense that you do not waste your time with whitespace issues. Sorry to bring that up.

-------------------------------------
