DESCRIPTION

Bug 440095 - [Contributions] Tooltips for command

Change-Id: Ic7b7b6fb529c97c5104855e474379cce2fe981a2
Signed-off-by: Lizbeth Webb xxx@xxx.xxx

COMMENTS

author: Addison Irwin
date: 2014-07-22 13:58:11.000000000

Patch Set 2: Verified+1 Code-Review+2

-------------------------------------
author: Addison Irwin
date: 2014-07-22 13:58:11.000000000

Change has been successfully merged into the git repository.

-------------------------------------
author: Teagan Marsh
date: 2014-07-22 14:10:25.000000000

Patch Set 2:

(1 comment)

Line:576, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/menus/CommandContributionItem.java -> This doesn't seem right: there is an existing "tooltip" field which will be ignored once a label has been set.

I think this logic needs to be duplicated for the tooltip.  Or put it into getToolTipText().

-------------------------------------
author: Addison Irwin
date: 2014-07-22 16:39:49.000000000

Patch Set 2:

(1 comment)

Line:576, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/menus/CommandContributionItem.java -> It seems to be fine - the tooltip here is a default value when the this.tooltip is null. See the getToolTipText method for more details

Daniel

-------------------------------------
