DESCRIPTION

Fixed bug 436645: [CommonNavigator] NavigatorContentDescriptorManager.EvaluationCache#getDescriptors does not work

Fix NavigatorContentDescriptorManager.EvaluationCache#getDescriptors to
lookup keys correctly.
Also added logic to remove stale entries more promptly thanks using
ReferenceQueues (can be moved to new commit if this is too drastic of a
change).

Change-Id: Ie057ec83cbd4a96aa755916bc1e2d54909224247
Signed-off-by: C. Kole Cochran xxx@xxx.xxx


COMMENTS

author: Kole Cochran
date: 2014-06-09 22:52:19.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-06-09 22:52:24.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2385/

-------------------------------------
author: Brenden Conley
date: 2014-06-09 23:01:39.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2385/ : SUCCESS

-------------------------------------
author: Slade Moran
date: 2014-06-11 13:43:01.000000000

Patch Set 3:

(1 comment)

Line:71, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationReference.java -> I'd do the type comparison (which is the type of the referent) to optimize further.

-------------------------------------
author: Kole Cochran
date: 2014-06-11 18:50:19.000000000

Patch Set 3:

(2 comments)

Line:175, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/NavigatorContentDescriptorManager.java -> This should just do a "dumb loop" to flush out the reference queues, not try to process references.

Line:71, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationReference.java -> You mean compare the types of the referrents? It is entirely valid for two unrelated types to nonetheless be equal to each other by the equals method.

Actually, there is a question, should these be equal only if the referents point to the exact same instance, not merely equals()?

If so, that would indeed be faster, though it might lead to some confusing behavior if you weren't expecting it (like one of the test cases).

-------------------------------------
author: Kole Cochran
date: 2014-06-14 00:06:58.000000000

Patch Set 3:

(1 comment)

Line:175, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/NavigatorContentDescriptorManager.java -> Done

-------------------------------------
