DESCRIPTION

Fixed bug 436645: [CommonNavigator]
NavigatorContentDescriptorManager.EvaluationCache#getDescriptors does
not work

Fix NavigatorContentDescriptorManager.EvaluationCache#getDescriptors to
lookup keys correctly.
Also added logic to remove stale entries more promptly using
ReferenceQueues (can be moved to new commit if this is too drastic of a
change).

Change-Id: Ie057ec83cbd4a96aa755916bc1e2d54909224247
Signed-off-by: C. Kole Cochran xxx@xxx.xxx


COMMENTS

author: Kole Cochran
date: 2015-07-09 20:12:02.000000000

Uploaded patch set 21.

-------------------------------------
author: Brenden Conley
date: 2015-07-09 20:12:09.000000000

Patch Set 21:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5956/

-------------------------------------
author: Brenden Conley
date: 2015-07-09 20:29:21.000000000

Patch Set 21: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5956/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2015-07-09 20:33:10.000000000

Patch Set 21: -Verified

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5957/

-------------------------------------
author: Brock Pruitt
date: 2015-07-09 20:49:41.000000000

Patch Set 21:

(13 comments)

Few nit-picks:

Line:456, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/NavigatorContentDescriptorManager.java -> non-Javadoc comments on methods xxx@xxx.xxx annotation provide no value but add clutter.

Line:11, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationValueReference.java -> Unnecessary blank line.

Line:24, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationValueReference.java -> Maps -> maps

Line:34, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationValueReference.java -> Unnecessary blank line.

Line:51, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationValueReference.java -> Unnecessary blank line.

Line:29, tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/NavigatorTestSuite.java -> Indentation is not consistent with prior lines.

Line:9, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationCache.java -> Indent lines 9-10 by 4 characters relative to line 8.

Line:27, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationCache.java -> Unnecessary blank line.

Line:75, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationCache.java -> Line too long.

Line:12, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationReference.java -> Unnecessary blank line.

Line:28, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationReference.java -> Unnecessary blank line.

Line:22, tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/util/TestNavigatorActivationService.java -> Unnecessary blank line.

Line:51, tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/util/TestNavigatorActivationService.java -> Unnecessary blank line.

-------------------------------------
author: Brenden Conley
date: 2015-07-09 20:49:57.000000000

Patch Set 21: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/5957/ : FAILURE

-------------------------------------
author: Kole Cochran
date: 2015-07-10 15:24:44.000000000

Patch Set 21:

(11 comments)

As far as I can tell, the build failures are due to unrelated breakages.

Line:456, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/NavigatorContentDescriptorManager.java -> Sorry, I missed this one when clearing these out.
Done.

Line:24, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationValueReference.java -> Done

Line:34, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationValueReference.java -> Done

Line:51, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationValueReference.java -> Done

Line:29, tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/NavigatorTestSuite.java -> Done

Line:9, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationCache.java -> Done

Line:27, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationCache.java -> Done

Line:75, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationCache.java -> Done

Line:28, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/EvaluationReference.java -> Done

Line:22, tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/util/TestNavigatorActivationService.java -> Done

Line:51, tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/util/TestNavigatorActivationService.java -> Done

-------------------------------------
