DESCRIPTION

Bug 436106 - [CSS] Color of the bar below view toolbar changes after
switching perspective

Change-Id: Ie266daa84035b40e1525e1a425dabdb1ce42fe6c
Signed-off-by: Addison Irwin xxx@xxx.xxx


COMMENTS

author: Addison Irwin
date: 2014-06-02 15:30:56.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-06-02 15:31:01.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2358/

-------------------------------------
author: Brenden Conley
date: 2014-06-02 15:40:37.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2358/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2014-06-02 17:28:23.000000000

Patch Set 1:

(3 comments)

I wish we could target some of these pieces a bit more precisely.  Perhaps we should tag the MPE's CTabFolder?

Line:345, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/helpers/CSSSWTColorHelper.java -> I can see the difference this makes for the show-list on CTabFolders, but it disables an optimization that seemed to make a difference for editors with lots of controls.  Could we tune this to only be disabled for CTabFolders?

Line:207, bundles/org.eclipse.ui.themes/css/e4_basestyle.css -> Can we not tailor this to only apply to the top-level CTabFolder for the multi-page editors?  (I don't know of any MPEs with a page containing a CTF, but …)

Line:211, bundles/org.eclipse.ui.themes/css/e4_basestyle.css -> ditto

-------------------------------------
