DESCRIPTION

Bug 435888 - NullpointerException in PartRenderingEngine#getPreferences

https://bugs.eclipse.org/bugs/show_bug.cgi?id=435888

return empty set of preferences if PlatformAdmin cannot be resolved

Change-Id: I260cfcff02125b27ebc4cafcd4aff24c3b0104a3
Signed-off-by: Kimberly Hunter xxx@xxx.xxx

COMMENTS

author: Kimberly Hunter
date: 2014-05-27 11:00:23.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-05-27 11:00:28.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2320/

-------------------------------------
author: Brenden Conley
date: 2014-05-27 11:10:07.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2320/ : SUCCESS

-------------------------------------
author: Slade Moran
date: 2014-05-27 13:11:45.000000000

Patch Set 1: Code-Review-1

(1 comment)

Line:1496, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java -> This should be Collections.emptySet().  You can change the type of prefs.

-------------------------------------
author: Kimberly Hunter
date: 2014-05-27 13:17:49.000000000

Patch Set 1:

(1 comment)

Line:1509, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java -> Are you sure about Collections.emptySet(). Here we have a prefs.add(...)

-------------------------------------
author: Slade Moran
date: 2014-05-27 13:25:25.000000000

Patch Set 1:

(1 comment)

Line:1509, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java -> I guess leave prefs alone then and simple return Collections.emptySet() from the admin==null if.

-------------------------------------
author: Kimberly Hunter
date: 2014-05-27 13:43:04.000000000

Patch Set 1:

(1 comment)

Line:1509, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java -> I aggree with Collections.emptySet() but what would be the drawback of just returning the empty HashSet as stated in my initial solution?

-------------------------------------
author: Slade Moran
date: 2014-05-27 13:59:51.000000000

Patch Set 1:

(1 comment)

Line:1509, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java -> It's an extra object for no reason.

-------------------------------------
