DESCRIPTION

[Bug 434485] [CSS] Theme-specific colors override user-configured colors
on restart

Change-Id: Id67e629c11ba0c2d142b5142f1f5fd8d6147aef7
Signed-off-by: Addison Irwin xxx@xxx.xxx


COMMENTS

author: Slade Moran
date: 2014-05-21 17:57:55.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-05-21 17:58:01.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2300/

-------------------------------------
author: Slade Moran
date: 2014-05-21 17:58:31.000000000

Patch Set 3: Code-Review+2

Just rebased.

-------------------------------------
author: Slade Moran
date: 2014-05-21 17:58:44.000000000

Patch Set 3: Verified+1

Just rebased.

-------------------------------------
author: Slade Moran
date: 2014-05-21 17:58:45.000000000

Change has been successfully merged into the git repository.

-------------------------------------
author: Brenden Conley
date: 2014-05-21 18:10:31.000000000

Patch Set 3:

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2300/ : SUCCESS

-------------------------------------
author: Teagan Marsh
date: 2014-05-21 18:38:54.000000000

Patch Set 3:

(1 comment)

I wonder if the EclipsePreferencesHelper shouldn't encode the theme-id when persisting out the changes.  So a user can see their changed values when switching back to a previously-customized theme.

Line:52, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/helpers/EclipsePreferencesHelper.java -> Won't this miss the situations where the property is the first or last element of the propertiesOverriddenByCSS string?

-------------------------------------
author: Slade Moran
date: 2014-05-21 18:45:36.000000000

Patch Set 3:

We could probably treat persisting per-theme changes as an enhancement.

-------------------------------------
author: Slade Moran
date: 2014-05-21 18:46:24.000000000

Patch Set 3:

(1 comment)

Line:52, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/helpers/EclipsePreferencesHelper.java -> We always encode the SEP at beginning and end, so even one property is SEPpropSEP.

-------------------------------------
