DESCRIPTION

Bug 414565 - [JFace][snippets] Update JFace snippets general cleanup

Refactorings and general cleanup.

Change-Id: Ib37e9c3e36dc900c07983aa0ea006354169c79c9
Signed-off-by: Jessica Roy xxx@xxx.xxx

COMMENTS

author: Jessica Roy
date: 2014-05-06 23:49:27.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-05-06 23:49:32.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2160/

-------------------------------------
author: Jessica Roy
date: 2014-05-06 23:50:35.000000000

Patch Set 2:

Lars, I tried to use List as suggested but the data didn't displayed correctly. Any ideas?

-------------------------------------
author: Brenden Conley
date: 2014-05-07 00:00:21.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2160/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-05-07 18:49:48.000000000

Patch Set 2: Code-Review-1

(8 comments)

Almost good

Line:299, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet058CellNavigationIn34.java -> Cool!

Line:68, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet063ComboViewer.java -> Use list

Line:79, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet054NativeControlsInViewers.java -> List

Line:83, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet053StartEditorWithContextMenu.java -> Use List as Interface

Line:105, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet052DouleClickCellEditor.java -> List

Line:122, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet052DouleClickCellEditor.java -> List

Line:215, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet055HideShowColumn.java -> Left side should be List

Line:68, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet004HideSelection.java -> Lists

-------------------------------------
