DESCRIPTION

Bug 414565 - [JFace][snippets] Update JFace snippets general cleanup 

Refactorings and general cleanup.

Change-Id: Ib37e9c3e36dc900c07983aa0ea006354169c79c9
Signed-off-by: Jessica Roy xxx@xxx.xxx

COMMENTS

author: Jessica Roy
date: 2014-05-06 21:18:22.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-05-06 21:18:28.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2159/

-------------------------------------
author: Brenden Conley
date: 2014-05-06 21:29:05.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2159/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-05-06 21:53:13.000000000

Patch Set 1:

(10 comments)

See inline comments

Line:243, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet061FakedNativeCellEditor.java -> Change that back

Line:298, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet058CellNavigationIn34.java -> Maybe add Hendrik, yourself and myself? :-)

Line:70, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet063ComboViewer.java -> Use Lists

Line:60, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet054NativeControlsInViewers.java -> Change that back

Line:79, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet054NativeControlsInViewers.java -> Use LIst

Line:40, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet052DouleClickCellEditor.java -> Replace with ArrayContentProvider

Line:74, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet052DouleClickCellEditor.java -> We typically set these flag directly in the constructor, I suggest to change that back

Line:141, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet052DouleClickCellEditor.java -> Use List<>

Line:48, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet004HideSelection.java -> We typically set these flag directly in the constructor, I suggest to change that back

Line:67, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet004HideSelection.java -> I guess a more modern version would use List<MyModel> as input. Can you adjust that?

-------------------------------------
