DESCRIPTION

Bug 433608 - Clean JFace Unit tests in preparation for GSoc

Refactored FieldAssistAPITests:
1. Moved test data to private field to make it visible for others test
methods.
2. Separated testSimpleContentProposal into more tests (Extract method).

Change-Id: I9749199b8709ed0367a6900fea99912d940c9d47
Signed-off-by: Jessica Roy xxx@xxx.xxx

COMMENTS

author: Jessica Roy
date: 2014-04-28 16:44:32.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-04-28 16:55:43.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2079/

-------------------------------------
author: Jessica Roy
date: 2014-04-28 16:56:42.000000000

Patch Set 1:

I have no idea why Hudson didn't start the build verification automatically.

-------------------------------------
author: Jessica Roy
date: 2014-04-28 16:57:15.000000000

Patch Set 1:

...Never mind.

-------------------------------------
author: Zaid Mosley
date: 2014-04-28 17:07:36.000000000

Patch Set 1:

Sometimes the build server is busy. FYI we are currently in a "freeze" period, in which we can only commit M7 relevant stuff. Change looks good to me, I commit it once we are free again.

-------------------------------------
author: Brenden Conley
date: 2014-04-28 17:08:53.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/2079/ : SUCCESS

-------------------------------------
author: Jessica Roy
date: 2014-04-28 17:33:44.000000000

Patch Set 1:

Makes a lot of sense. Thanks Lars.

-------------------------------------
