DESCRIPTION

Bug 432146 - Use new find method of EModelService in DnDProcessor,
CleanupProcessor, MinMaxProcessor and SplitterProcessor

- Add an util class to prevent copy and paste of the same code

Change-Id: If30c2ea314aba278afd3fbd118f6f502b59a83c8
Signed-off-by: Owen Strickland xxx@xxx.xxx


COMMENTS

author: Owen Strickland
date: 2014-04-07 16:10:57.000000000

Uploaded patch set 3.

-------------------------------------
author: Zaid Mosley
date: 2014-04-07 16:16:50.000000000

Patch Set 3: Code-Review+1 Verified+1

(5 comments)

Looks perfect to me, I think you deserve that your name is added to the copyright :) please add yourself

Line:10, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/swt/DnDProcessor.java -> Add yourself

Line:2, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/swt/ProcessorUtil.java -> I think you can claim the copyright for this file

Line:9, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/swt/ProcessorUtil.java -> No it was you :)

Line:10, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/swt/SplitterProcessor.java -> Please add yourself here also

Line:10, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/swt/MinMaxProcessor.java -> Add yourself

-------------------------------------
author: Owen Strickland
date: 2014-04-07 16:31:04.000000000

Patch Set 3:

(1 comment)

Line:2, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/swt/ProcessorUtil.java -> What i'm suppose to write there?

-------------------------------------
author: Zaid Mosley
date: 2014-04-07 17:42:24.000000000

Patch Set 3:

Looks perfect to me, I think you deserve that your name is added to the copyright :) please add yourself

-------------------------------------
author: Brenden Conley
date: 2014-04-07 18:03:52.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1776/

-------------------------------------
author: Brenden Conley
date: 2014-04-07 18:18:39.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1776/ : SUCCESS

-------------------------------------
author: Owen Strickland
date: 2014-04-09 02:21:40.000000000

Abandoned

Due to problem with my email, I needed to clear my git repo.  An I forgot that I can fetch from gerrit. I re-summited the change in another gerrit

-------------------------------------
