DESCRIPTION

Bug 401439 - [CSS] reoccuring widget is disposed errors

Change-Id: I6752185a99c67035bfffbb4930a32cc3ea63b53c
Signed-off-by: Arturo Copeland xxx@xxx.xxx

COMMENTS

author: Arturo Copeland
date: 2014-04-06 20:51:26.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-04-06 20:51:31.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1749/

-------------------------------------
author: Brenden Conley
date: 2014-04-06 21:05:51.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1749/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-04-07 06:13:34.000000000

Patch Set 1: Code-Review-1

(4 comments)

See inline comments

Line:79, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/CTabFolderElement.java -> We don't put Bug numbers into comments, we have Git for this.

Line:106, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/CTabFolderElement.java -> Is this a change? Typically I don't want formatting changes in lines which are not affected

Line:127, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/CTabFolderElement.java -> Is this a change? Typically I don't want formatting changes in lines which are not affected

Line:136, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/CTabFolderElement.java -> Is this a change? Typically I don't want formatting changes in lines which are not affected

-------------------------------------
author: Arturo Copeland
date: 2014-04-07 08:23:29.000000000

Patch Set 1:

Although this removes the exception, the internal issue remains -> TabItems are disposed but left in the TabFolder's items list.  It happens 1/100 times.  I am working on tracking this down.

-------------------------------------
author: Arturo Copeland
date: 2014-04-07 08:30:21.000000000

Patch Set 1:

(1 comment)

Line:106, bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/dom/CTabFolderElement.java -> Not a change related to issue.  I'll have a talk with the code formatter and let her know to back off.

-------------------------------------
author: Zaid Mosley
date: 2014-04-07 09:49:01.000000000

Patch Set 1:

> I'll have a talk with the code formatter and let her know to back off.

Not pressing Ctrl+Shift+F should do the trick. :) Project is already set to format the edited lines alreadz.

-------------------------------------
