DESCRIPTION

Fixed bug 431924: [Preferences]
org.eclipse.ui.internal.preferences.WorkingCopy.keys() returns removed
keys

Changed keys-method to add to or remove from results any temporary keys
based on if the key's value is null.

Change-Id: Ia7bbbd2d5863a5c4fa32b3030034b0d906c2bdbe
Signed-off-by: Yair Travis xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-04-08 20:22:56.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1817/

-------------------------------------
author: Slade Moran
date: 2014-04-08 20:24:53.000000000

Patch Set 2: Code-Review-1

(1 comment)

Line:473, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/preferences/WorkingCopyPreferences.java -> I'd change the temporarySettings to a Map<String, Object>.  Then iterate the entries(), not just keys, and you won't need the extra gets.

-------------------------------------
author: Brenden Conley
date: 2014-04-08 20:38:08.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1817/ : SUCCESS

-------------------------------------
author: Yair Travis
date: 2014-04-08 22:55:31.000000000

Patch Set 2:

(1 comment)

Line:473, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/preferences/WorkingCopyPreferences.java -> Done

-------------------------------------
