DESCRIPTION

Bug 432064 - ModelServiceImpl possible NPE and ClassCastException

Change-Id: I7237cded1b337ac535ec5a8f82625deeed744615
Signed-off-by: Owen Strickland xxx@xxx.xxx


COMMENTS

author: Owen Strickland
date: 2014-04-05 02:08:20.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-04-05 02:08:25.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1743/

-------------------------------------
author: Brenden Conley
date: 2014-04-05 02:23:33.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1743/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-04-05 10:01:37.000000000

Patch Set 1: Code-Review-1

(3 comments)

Line:139, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java -> I think we should leave this check it to give early feedback is someone uses it incorrect. Javadoc alone is not sufficient IHMO

Line:243, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/EModelServiceFindTest.java -> Whitespace

Line:245, tests/org.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/application/EModelServiceFindTest.java -> Whitespace

-------------------------------------
author: Owen Strickland
date: 2014-04-05 14:59:45.000000000

Patch Set 1:

(2 comments)

Line:139, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java -> The parameter check is in the method findElementsRecursive.....I just added the match method because I need to call the same logic twice. 
Check comment bellow

Line:148, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/ModelServiceImpl.java -> The check for not null parameter is there

-------------------------------------
