DESCRIPTION

Bug 193095 - MarkerView doesn't use Util.getAdapter(*) 

Change-Id: Ia22eed77b24824379af8b87671f7e605912971e1
Signed-off-by: Krista Shepherd xxx@xxx.xxx

COMMENTS

author: Krista Shepherd
date: 2014-03-28 19:55:07.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2014-03-29 02:14:36.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1584/

-------------------------------------
author: Brenden Conley
date: 2014-03-29 02:28:46.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1584/ : SUCCESS

-------------------------------------
author: Slade Moran
date: 2014-03-31 19:55:11.000000000

Patch Set 4: Code-Review-1

(1 comment)

Line:1147, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerView.java -> Why does this have to be an instanceof IAdaptable?

-------------------------------------
author: Krista Shepherd
date: 2014-03-31 21:02:58.000000000

Patch Set 4:

(1 comment)

See inline comment

Line:1147, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerView.java -> The reason is that the org.eclipse.ui.views.tasklist.ITaskListResourceAdapter.getAffectedResource(IAdaptable) method unfortunately expects an IAdaptable as parameter. Therefore the object must be an instanceof IAdaptable. I would have prefered to pass the plain object in order to use the Util.getAdapter(*) functionality either in the ITaskListResourceAdapter implementations, but that may break other existing implementations of the ITaskListResourceAdapter. I propose to also use the Util.getAdapter(*) inside the default ITaskListResourceAdapter implementations. (DefaultMarkerResourceAdapter and DefaultTaskListResourceAdapter)

-------------------------------------
author: Slade Moran
date: 2014-04-03 20:13:18.000000000

Patch Set 5: Patch Set 4 was rebased

-------------------------------------
