DESCRIPTION

Bug 354538 - [Contributions] [Compatibility] Window menus and toolbars
leaked after having been closed

Change-Id: Id20b0f96daf07fd343e9660b2c061b6da40f915f
Signed-off-by: Addison Irwin xxx@xxx.xxx

COMMENTS

author: Slade Moran
date: 2014-04-04 16:17:27.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2014-04-04 16:17:32.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1738/

-------------------------------------
author: Brenden Conley
date: 2014-04-04 16:32:50.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1738/ : SUCCESS

-------------------------------------
author: Slade Moran
date: 2014-04-04 17:47:45.000000000

Patch Set 4: Code-Review-1

(2 comments)

Line:416, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerRenderer.java -> This has to manage the other records.

Line:384, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerRenderer.java -> This can't go from a list of contribution records to one.  There can be multiple contribution records applied to menu model elements.  I believe getContributionRecord(menuModel) returns the first CR that created a model element.

-------------------------------------
