DESCRIPTION

Bug 354538 - [Contributions] [Compatibility] Window menus and toolbars
leaked after having been closed

Change-Id: Id20b0f96daf07fd343e9660b2c061b6da40f915f
Signed-off-by: Addison Irwin xxx@xxx.xxx

COMMENTS

author: Addison Irwin
date: 2014-03-28 16:03:13.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-03-28 16:03:18.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1544/

-------------------------------------
author: Brenden Conley
date: 2014-03-28 16:19:06.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1544/ : SUCCESS

-------------------------------------
author: Addison Irwin
date: 2014-03-28 16:39:49.000000000

Patch Set 2:

The 2nd patch decreases the memory leaks only. It doesn't eliminate it. So if you want we can use it as some kind of the improvement.

Please let me know if you see other options how to fix it and I will prepare the proper patch.

thanks,
Daniel

-------------------------------------
author: Slade Moran
date: 2014-03-28 16:58:45.000000000

Patch Set 2:

(2 comments)

2 comments inline

Line:275, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerRenderer.java -> The call to super dispose should probably be at the end.

Line:317, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Should probably be at the end of the method.

-------------------------------------
