DESCRIPTION

Bug 355010 - [CSS] Understand default behaviour if product doesn't
specify a theme

Change-Id: I13aee36b89afa84faca5824e587a91dae381fbc3
Signed-off-by: Addison Irwin xxx@xxx.xxx


COMMENTS

author: Addison Irwin
date: 2014-03-24 12:22:59.000000000

Uploaded patch set 1.

-------------------------------------
author: Slade Moran
date: 2014-03-24 12:51:14.000000000

Patch Set 1:

(1 comment)

Line:1363, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java -> Any reason why we're not getting this OSGi service out of the appContext (so we get it from the OSGi EclipseContext)?

-------------------------------------
author: Brenden Conley
date: 2014-03-24 12:57:03.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1427/

-------------------------------------
author: Addison Irwin
date: 2014-03-24 13:05:21.000000000

Patch Set 1:

(1 comment)

Line:1363, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java -> Unfortunately I'm not aware why it was implemented in this way. Do want to modify it and get the IThemeEngine service from the app context?

-------------------------------------
author: Slade Moran
date: 2014-03-24 13:10:26.000000000

Patch Set 1:

(1 comment)

Line:1363, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java -> Yes, please.  Since we're just grabbing the service without any of the regular OSGi protection, we may as well just grab it from the IEclipseContext.

-------------------------------------
author: Brenden Conley
date: 2014-03-24 13:12:18.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1427/ : SUCCESS

-------------------------------------
