DESCRIPTION

Bug 428355 - [New Contributors] Fix warnings in platform projects


Change-Id: Iddbcf466cd243cea7c90098ad6623e4cd951245d
Signed-off-by: Owen Strickland xxx@xxx.xxx

COMMENTS

author: Owen Strickland
date: 2014-03-20 23:37:09.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2014-03-20 23:53:41.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1379/

-------------------------------------
author: Brenden Conley
date: 2014-03-21 00:07:43.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1379/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-03-21 12:41:23.000000000

Patch Set 3: Patch Set 2 was rebased

-------------------------------------
author: Zaid Mosley
date: 2014-03-21 12:44:30.000000000

Patch Set 2:

(2 comments)

I think this uses the wrong Handler and I'm not sure if the introduction of Generics into the public method is an API change or not.

Paul, can you clarify that?

Line:47, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/commands/AbstractHandler.java -> Should this be org.eclipse.core.commands.IHandlerListener?

Line:172, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/commands/AbstractHandler.java -> Paul is this an API change or is this OK?

-------------------------------------
