DESCRIPTION

Bug 428355 - [New Contributors] Fix warnings in platform projects

Method => protected Collection getSelectionValue() have been removed as
well, no others methods call it

Change-Id: I6b3b64e9da6f812cbc16a0de25c7a4825ee4ee82
Signed-off-by: Owen Strickland xxx@xxx.xxx

COMMENTS

author: Owen Strickland
date: 2014-03-19 20:39:39.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-03-19 20:40:29.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1353/

-------------------------------------
author: Brenden Conley
date: 2014-03-19 20:54:18.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1353/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-03-19 23:41:52.000000000

Patch Set 1: Code-Review+1

Looks good, need to spend a bit more time to review it.

-------------------------------------
author: Zaid Mosley
date: 2014-03-25 11:25:20.000000000

Patch Set 1:

(1 comment)

Line:309, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/about/AboutFeaturesPage.java -> Enhanced for loop?

-------------------------------------
author: Owen Strickland
date: 2014-03-25 13:12:36.000000000

Patch Set 1:

(1 comment)

Line:309, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/about/AboutFeaturesPage.java -> What do you mean? Change it for an Enhanced for loop?

-------------------------------------
author: Zaid Mosley
date: 2014-03-25 22:49:40.000000000

Patch Set 1:

(1 comment)

Line:309, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/about/AboutFeaturesPage.java -> Yes, should be possible here, I think.

-------------------------------------
author: Zaid Mosley
date: 2014-04-01 15:55:10.000000000

Patch Set 1:

Please remove dependency to the other changes...

-------------------------------------
author: Zaid Mosley
date: 2014-04-01 15:55:12.000000000

Patch Set 1: Code-Review-1 IP-Clean-1 Verified-1

Please remove dependency to the other changes...

-------------------------------------
author: Owen Strickland
date: 2014-04-02 16:48:30.000000000

Abandoned

Instead of getting fetching it from gerrit and rebase it on master.  I will redo the change later....it will be faster!

-------------------------------------
