DESCRIPTION

Bug 430116 - Wrong action bar population

IMenuManager children should not be added to the menu manager parent 
toolbar. 
ToolbarManagerRenderer should add an element already present in the 
toolbar manager contributions

Change-Id: I4b77eabef0ba6f2575a1564a2b47de04f1e2e29a
Author: Quintin Stokes xxx@xxx.xxx
Also-by: Amiyah Parrish xxx@xxx.xxx
Signed-off-by: Amiyah Parrish xxx@xxx.xxx Stokes
xxx@xxx.xxx


COMMENTS

author: Zaid Mosley
date: 2014-03-31 18:27:46.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2014-03-31 18:27:51.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1644/

-------------------------------------
author: Zaid Mosley
date: 2014-03-31 18:30:29.000000000

Patch Set 4: Code-Review+2 IP-Clean+1 Verified+1

Thanks Maxime for the contribution. Looks good to me.

-------------------------------------
author: Zaid Mosley
date: 2014-03-31 18:35:15.000000000

Patch Set 4: -Code-Review

(1 comment)

Except that you may want to add "continue" to the if statement to make it clear that the item should be skipped.

Line:557, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java -> add continue; here?

-------------------------------------
author: Brenden Conley
date: 2014-03-31 18:42:28.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1644/ : SUCCESS

-------------------------------------
author: Lilia Joyce
date: 2014-04-01 08:30:51.000000000

Patch Set 4:

(1 comment)

Hi Lars, 

I will try to do this this afternoon.

Line:557, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java -> I will propose a new patch set with the continue here.

-------------------------------------
author: Amiyah Parrish
date: 2014-04-01 08:54:14.000000000

Patch Set 4:

(1 comment)

See also my comment in the code. Thanks!

Line:577, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java -> Maxime, please preserve this comment in your new patch. Also you can remove me from the commit message. It is a result of a small misunderstanding with bug 429900.

-------------------------------------
author: Lilia Joyce
date: 2014-04-01 13:28:30.000000000

Patch Set 4:

(1 comment)

Line:577, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java -> Done

-------------------------------------
