DESCRIPTION

Bug 380946 - [Commands] [Compatibility] helpContextId not registered for
legacy handlers


Change-Id: I5f852925ba6b459f2d6e3f2642de0c89b794de3a
Signed-off-by: Amiyah Parrish xxx@xxx.xxx


COMMENTS

author: Amiyah Parrish
date: 2014-03-13 17:31:17.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2014-03-13 17:31:22.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1239/

-------------------------------------
author: Amiyah Parrish
date: 2014-03-13 17:38:53.000000000

Patch Set 1:

This is not final fix but an experimental code.

-------------------------------------
author: Brenden Conley
date: 2014-03-13 17:40:07.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1239/ : FAILURE

-------------------------------------
author: Slade Moran
date: 2014-03-27 18:51:20.000000000

Patch Set 1: Code-Review-1

(3 comments)

Line:133, bundles/org.eclipse.e4.core.commands/src/org/eclipse/e4/core/commands/internal/HandlerServiceHandler.java -> This will return the E4ProxyHandler most of the time.  Is that going to match what needs to be looked up?

File Comment: tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/commands/CommandsTestSuite.java -> Can't have most of the tests disabled (probably included by mistake :-)

File Comment: tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/UiTestSuite.java -> Can't have most of the tests disabled.

-------------------------------------
author: Amiyah Parrish
date: 2014-05-09 21:40:14.000000000

Abandoned

fixed in another commit

-------------------------------------
