DESCRIPTION

Bug 398852 - [CSS] Un-readable tab names when using High Contrast mode

Change-Id: Ibbdff2febebdd6525e423ad8f3a9ee447b344bf8
Signed-off-by: Addison Irwin xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-04-07 15:29:21.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1766/

-------------------------------------
author: Brenden Conley
date: 2014-04-07 15:44:37.000000000

Patch Set 5: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1766/ : SUCCESS

-------------------------------------
author: Slade Moran
date: 2014-04-08 14:58:25.000000000

Patch Set 5:

(1 comment)

Line:1249, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java -> AFAIK this method always returns null on linux

-------------------------------------
author: Addison Irwin
date: 2014-04-08 15:35:40.000000000

Patch Set 5:

(1 comment)

Line:1249, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java -> We use this check in the several places of the Workbench, including the popup dialog with the 'High Contrast Mode Change' message. I don't know if we have sth better to figure out the High contrast mode

-------------------------------------
author: Slade Moran
date: 2014-04-09 20:18:25.000000000

Patch Set 5:

(1 comment)

Line:1249, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.java -> I guess it'll have to do.

-------------------------------------
author: Sebastian Porter
date: 2014-04-10 12:37:57.000000000

Patch Set 5: Verified+1

I verified that the last change set works and allows to modify the colors. While not ideal, I can live with theme combo being read-only for now.

-------------------------------------
