DESCRIPTION


Initial Work for Bug 424367 - [Model] EModelService - define a more
generic 'find' API

Change-Id: I77ad8f190266483285d0ec9e5ba6d265094b473d



COMMENTS

author: Jared Jackson
date: 2014-02-21 16:30:26.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2014-02-21 16:30:32.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/978/

-------------------------------------
author: Brenden Conley
date: 2014-02-21 16:41:35.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/978/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-02-21 20:20:47.000000000

Patch Set 3:

(1 comment)

Just some style-nits with the code, lots of unnecessary whitespace.

Line:22, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/workbench/modeling/ElementMatcher.java -> If you start using Eclipse M5 or later JDT will not insert with unnecessary whitespacse anymore.

-------------------------------------
author: Slade Moran
date: 2014-02-24 15:10:33.000000000

Patch Set 3:

(2 comments)

A question about javadoc and a suggested code change.

Line:45, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/workbench/modeling/ElementMatcher.java -> while minor, you can probably change this to:
if (tab != null) {
    tagsToMatch = Arrays.asList(tag);
}

Line:157, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/workbench/modeling/EModelService.java -> Is this true if they search for handlers?

-------------------------------------
author: Jared Jackson
date: 2014-02-28 15:23:02.000000000

Patch Set 4: Patch Set 3 was rebased

-------------------------------------
