DESCRIPTION

Bug 410426 - VisibleWhen from contribution factories not handled in
toolbars

ToolbarContributionRecord did not handle the factory case in
anyVisibleWhen() and always return false for contributions through
org.eclipse.ui.menus.ExtensionContributionFactory.

This commit also correct a ClassCastException in
ToolBarManagerRenderer.toBeRenderedUpdater EventHandler: the
IContributionItem is not always a ContributionItem, it could be a
MenuManager too. 

Bug410426Test contains two tests which checks the corrected behaviors.

Change-Id: I5fd8b73ab8224fe9bd549549fac5eb0daf1b322f
Signed-off-by: Quintin Stokes xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2014-02-13 15:30:26.000000000

Patch Set 8:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/857/

-------------------------------------
author: Brenden Conley
date: 2014-02-13 15:41:41.000000000

Patch Set 8: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/857/ : SUCCESS

-------------------------------------
author: Slade Moran
date: 2014-02-13 15:49:03.000000000

Patch Set 8: Code-Review+2 IP-Clean+1

-------------------------------------
author: Slade Moran
date: 2014-02-13 15:49:06.000000000

Change has been successfully merged into the git repository.

-------------------------------------
