DESCRIPTION

Bug 401655 - [Progress] Create e4 based Progress View

Refactor the workLeon Ochoach Progress view to run on Eclipse4. Includes:
- Progress support
- Eclipse4 ProgressView
- progress toolbar
- replaces 3.x services with their 4.x equivalents
- progress view preferences dialog
- example model fragments
- explicit singletons replaced with dependency injection
- general refactoring
- remove dos line endings

Change-Id: If30658d0150b9933165546629cfe17f94ee41caa
Signed-off-by: Amiyah Parrish xxx@xxx.xxx


COMMENTS

author: Slade Moran
date: 2014-02-20 16:27:23.000000000

Uploaded patch set 11.

-------------------------------------
author: Brenden Conley
date: 2014-02-20 16:34:24.000000000

Patch Set 11:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/946/

-------------------------------------
author: Alvin Suarez
date: 2014-02-20 16:36:07.000000000

Patch Set 11:

I just realized that the change contains EventLoopProgressMonitor class, but it doesn't belong to the progress view, does it?

-------------------------------------
author: Brenden Conley
date: 2014-02-20 16:46:21.000000000

Patch Set 11: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/946/ : SUCCESS

-------------------------------------
author: Slade Moran
date: 2014-02-20 16:55:39.000000000

Patch Set 11:

(9 comments)

Line:12, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/ProgressView.java -> This should be internal.

Line:12, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/OpenProgressViewHandler.java -> This should probably be internal.

Line:48, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/WorkLeon OchoachSiteProgressService.java -> This can probably be deleted from the e4 progress viewer and left in the Workbench.

Line:12, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/ClearAllHandler.java -> This should probably be internal

Line:44, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/IWorkLeon OchoachSiteProgressService.java -> Can this be left in Workbench?  The implementation only makes sense in the workbench progress service.

Line:5, bundles/org.eclipse.e4.ui.progress/META-INF/MANIFEST.MF -> Let's set this version to 0.1.0.qualifier. Then the pom.xml file should have 0.1.0-SNAPSHOT

Line:12, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/ShowPreferencesHandler.java -> This should be internal.

Line:24, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/ShowPreferencesHandler.java -> This method name needs to be updated to not look like a constructor.

Line:12, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/ProgrammaticProgressView.java -> This should probably be internal.

-------------------------------------
