DESCRIPTION

Bug 398837 - [RenderingEngine] We need to revamp the e4 life cycle
handling

Change-Id: I79298eae6589ad0bcce80ca5bdf5f021577cf496


COMMENTS

author: Slade Moran
date: 2014-01-29 18:57:29.000000000

Uploaded patch set 8.

-------------------------------------
author: Brenden Conley
date: 2014-01-29 18:57:34.000000000

Patch Set 8:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/682/

-------------------------------------
author: Brenden Conley
date: 2014-01-29 19:07:45.000000000

Patch Set 8: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/682/ : SUCCESS

-------------------------------------
author: Mariela Flores
date: 2014-01-29 19:48:25.000000000

Patch Set 8:

I would prefer calling ALL handlers:

public boolean process(Class<? extends Annotation> annotation, MLifecycleAware element,
			IEclipseContext localContext) {
		IEclipseContext context = modelService.getContainingContext((MUIElement) element);
		if (context == null)
			context = application.getContext();

		boolean rv = true;
		// First iterate over the local LC handlers
		for (MLifecycleContribution c : element.getLifeCycleHandlers()) {
			rv &= runLCHandler(c, annotation, element, context, localContext);
		}

		// Now iterate over the 'global' LC handlers
		for (MLifecycleContribution c : application.getLifeCycleHandlers()) {
			rv &= runLCHandler(c, annotation, element, context, localContext);
		}

		return rv;
	}

-------------------------------------
