DESCRIPTION

Bug 426572 - [CSS] CSS does not work with Eclipse 4.4

Change-Id: Id4f2c52830ef2dd72334ae8eddc1b69d86a538ca
Signed-off-by: Addison Irwin xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2014-01-27 11:04:01.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/646/

-------------------------------------
author: Slade Moran
date: 2014-01-27 11:24:49.000000000

Patch Set 1:

So we only set it to the default theme if neither arg is set.  Will it cause a problem if the themeId == null, or is that OK?

-------------------------------------
author: Brenden Conley
date: 2014-01-27 11:26:33.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/646/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-01-27 11:27:19.000000000

Patch Set 1: Verified+1 Code-Review+2 IP-Clean+1

Thanks, looks fine.

-------------------------------------
author: Zaid Mosley
date: 2014-01-27 11:27:20.000000000

Change has been successfully merged into the git repository.

-------------------------------------
author: Zaid Mosley
date: 2014-01-27 11:27:42.000000000

Patch Set 1: Reverted

This patchset was reverted in change: Ieb5f38c22ae179e6b120a069246cb97b1b7f5bea

-------------------------------------
author: Zaid Mosley
date: 2014-01-27 11:28:52.000000000

Patch Set 1:

Sorry, pressed the wrong button. I wanted to review but pressed review and submit. I reverted the change I submitted, I hope this does not created any issue.

-------------------------------------
author: Addison Irwin
date: 2014-01-27 11:35:47.000000000

Patch Set 1:

> So we only set it to the default theme if neither arg is set. Will it cause a problem if the themeId == null, or is that OK?

It will be OK,
Daniel

-------------------------------------
