DESCRIPTION

Bug 426535 - [Trim] Allow to close toolbars via right click menu ->
Close

Change-Id: Icd01bd93fe282519b71ee8425451119e19a33cd5
Signed-off-by: Zaid Mosley xxx@xxx.xxx

COMMENTS

author: Zaid Mosley
date: 2014-04-02 20:17:09.000000000

Uploaded patch set 6.

-------------------------------------
author: Brenden Conley
date: 2014-04-02 20:17:14.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1692/

-------------------------------------
author: Slade Moran
date: 2014-04-02 20:21:19.000000000

Patch Set 6: Code-Review-1

(2 comments)

Line:404, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Shouldn't this menu reflect either hide or show?  Or does this one menu apply to the entire MTrimBar?

Line:193, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/workbench/IPresentationEngine.java -> Wouldn't add the API for Luna though.

-------------------------------------
author: Zaid Mosley
date: 2014-04-02 20:30:49.000000000

Patch Set 6:

(2 comments)

See answer to your comments

Line:404, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/ToolBarManagerRenderer.java -> Hide works on the toolbar but show works for all hidden.  You cannot select a menu on a hidden toolbar so to show the hidden toolbar you can use the context menu of the still visible toolbars.

This was suggested to Eric IIRC.

Line:193, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/workbench/IPresentationEngine.java -> OK, I place it in ToolBarManagerRenderer

-------------------------------------
author: Brenden Conley
date: 2014-04-02 20:32:25.000000000

Patch Set 6: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1692/ : SUCCESS

-------------------------------------
author: Gerrit Code Review
date: 2014-04-03 18:30:36.000000000

Change could not be merged because of a missing dependency.

The following changes must also be submitted:

* I3d62c2ffb2face81ede41cb4736473f7c7a228cf


-------------------------------------
