DESCRIPTION

Bug 426535 - [Trim] Allow to close toolbars via right click menu ->
Close

Change-Id: Icd01bd93fe282519b71ee8425451119e19a33cd5
Signed-off-by: Zaid Mosley xxx@xxx.xxx

COMMENTS

author: Gerrit Code Review
date: 2014-04-03 18:30:36.000000000

Change could not be merged because of a missing dependency.

The following changes must also be submitted:

* I3d62c2ffb2face81ede41cb4736473f7c7a228cf


-------------------------------------
author: Zaid Mosley
date: 2014-04-03 18:35:40.000000000

Uploaded patch set 10.

-------------------------------------
author: Brenden Conley
date: 2014-04-03 19:04:23.000000000

Patch Set 10:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1709/

-------------------------------------
author: Slade Moran
date: 2014-04-03 19:05:26.000000000

Patch Set 10: Code-Review-1

Why is that in the IDE plugin?  If we can make the disappear in the workLeon Ochoach we need to recover them from the workbench,no?

-------------------------------------
author: Slade Moran
date: 2014-04-03 19:06:58.000000000

Patch Set 10:

(1 comment)

Line:39, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/handlers/ResetToolbarVisibilityHandler.java -> Shouldn't this method just call the appropriate method on the ToolBarManagerRenderer?

-------------------------------------
author: Brenden Conley
date: 2014-04-03 19:18:41.000000000

Patch Set 10: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/1709/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-04-04 09:03:32.000000000

Patch Set 10:

Thanks Paul, after thinking about it for a while, I think the correct thing is to add the reset of the tag into the resetPerspective functionality. Users are used to use that to reset their perspective.

-------------------------------------
