DESCRIPTION

Bug 37478: Add options to import filesystem as project in FS wizard

The "Import from filesystem" wizard now supports multiple strategy
to allow either:
* Import of a directory as a new project
* Import of an existing project
* Import of resources into an existing project

Signed-off-by: Isis Velasquez xxx@xxx.xxx
Change-Id: I4209b7dfddfe7d1120d6f2124dd3de4f9d3ae703


COMMENTS

author: Brenden Conley
date: 2014-01-15 15:20:24.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/554/

-------------------------------------
author: Sebastian Porter
date: 2014-01-15 15:30:22.000000000

Patch Set 4: Code-Review-2

I get 10 errors when I check out that change (API Tools errors and unused stuff).

-------------------------------------
author: Brenden Conley
date: 2014-01-15 15:31:53.000000000

Patch Set 4: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/554/ : SUCCESS

-------------------------------------
author: Sebastian Porter
date: 2014-01-15 15:37:32.000000000

Patch Set 4:

When starting a target workspace I get this in the console:

Warning: NLS unused message: WizardImportPage_project in: org.eclipse.ui.internal.ide.messages

-------------------------------------
author: Isis Velasquez
date: 2014-01-15 15:38:26.000000000

Patch Set 4:

Thanks for feedback. I'll review this change and try to fix API Tools (I didn't have a baseline enabled while writing this code).

-------------------------------------
author: Sebastian Porter
date: 2014-01-15 16:08:52.000000000

Patch Set 4: Verified-1

I then chose to import an 'Archive File' and got an NPE [1].

Some other things I noticed on a first glance (didn't do a full test pass):
- it does not import but creates and links to the directory
- the 'From directory' no longer seems to store the previously used values
- options should use sentence style
- mnemonics are missing

Regarding the behavior: maybe it's better if we first discuss in the bug to what we agree what the dialog should exactly do in the future.


[1]

!ENTRY org.eclipse.jface 4 2 2014-01-15 16:38:50.927
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.jface".
!STACK 0
java.lang.NullPointerException
	at org.eclipse.ui.internal.wizards.datatransfer.WizardFileSystemResourceImportPage1.updateWidgetEnablements(WizardFileSystemResourceImportPage1.java:1270)
	at org.eclipse.ui.internal.wizards.datatransfer.WizardFileSystemResourceImportPage1.createControl(WizardFileSystemResourceImportPage1.java:313)
	at org.eclipse.ui.internal.wizards.datatransfer.WizardArchiveFileResourceImportPage1.createControl(WizardArchiveFileResourceImportPage1.java:107)
	at org.eclipse.jface.wizard.Wizard.createPageControls(Wizard.java:174)
	at org.eclipse.jface.wizard.WizardDialog.createPageControls(WizardDialog.java:757)
	at org.eclipse.jface.wizard.WizardDialog.setWizard(WizardDialog.java:1206)
	at org.eclipse.jface.wizard.WizardDialog.updateForPage(WizardDialog.java:1265)
	at org.eclipse.jface.wizard.WizardDialog.access$4(WizardDialog.java:1262)
	at org.eclipse.jface.wizard.WizardDialog$8.run(WizardDialog.java:1251)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.jface.wizard.WizardDialog.showPage(WizardDialog.java:1249)
	at org.eclipse.ui.internal.dialogs.ImportExportPage.treeDoubleClicked(ImportExportPage.java:251)
	at org.eclipse.ui.internal.dialogs.ImportPage$2.doubleClick(ImportPage.java:72)
	at org.eclipse.jface.viewers.StructuredViewer$1.run(StructuredViewer.java:849)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:176)
	at org.eclipse.jface.viewers.StructuredViewer.fireDoubleClick(StructuredViewer.java:847)
	at org.eclipse.jface.viewers.AbstractTreeViewer.handleDoubleSelect(AbstractTreeViewer.java:1487)
	at org.eclipse.jface.viewers.StructuredViewer$4.widgetDefaultSelected(StructuredViewer.java:1254)
	at org.eclipse.jface.util.OpenStrategy.fireDefaultSelectionEvent(OpenStrategy.java:252)
	at org.eclipse.jface.util.OpenStrategy.access$0(OpenStrategy.java:249)
	at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:310)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4351)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1061)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4170)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3759)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:827)
	at org.eclipse.jface.window.Window.open(Window.java:803)
	at org.eclipse.ui.internal.handlers.WizardHandler$Import.executeHandler(WizardHandler.java:152)
	at org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:279)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:290)
	at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:601)
	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
	at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:243)
	at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:224)
	at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
	at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:163)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
	at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:222)
	at org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:420)
	at org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:157)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:588)
	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:505)
	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:415)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4351)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1061)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4170)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3759)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1122)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.swt.PartRenderingEngine.run(PartRenderingEngine.java:1006)
	at org.eclipse.e4.ui.internal.workLeon Ochoach.E4Workbench.createAndRunUI(E4Workbench.java:146)
	at org.eclipse.ui.internal.WorkLeon Ochoach$5.run(Workbench.java:612)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.WorkLeon Ochoach.createAndRunWorkbench(Workbench.java:565)
	at org.eclipse.ui.PlatformUI.createAndRunWorkLeon Ochoach(PlatformUI.java:150)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:125)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:109)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:80)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:372)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:226)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:601)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1426)

-------------------------------------
