DESCRIPTION

Bug 318435 - [Contributions] Changes in the application model for the
menu are not reflected in the user interface

Change-Id: I8da9d3c4d0fa01ee7cad85f920cad923c455e6e8
Signed-off-by: Chase Horton xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-11-18 18:35:31.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/239/

-------------------------------------
author: Brenden Conley
date: 2013-11-18 18:50:10.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/239/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2013-11-18 19:08:43.000000000

Patch Set 1:

(4 comments)

Looks in general good. Some minor suggestion inline.

Line:884, bundles/org.eclipse.jface/src/org/eclipse/jface/action/MenuManager.java -> Whitespace

Line:1015, bundles/org.eclipse.jface/src/org/eclipse/jface/action/MenuManager.java -> Maybe xxx@xxx.xxx menuText The text for the menu.

Line:1026, bundles/org.eclipse.jface/src/org/eclipse/jface/action/MenuManager.java -> setImageDescriptor would be more fitting IMHO

Line:11, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerRenderer.java -> Please remove whitespace

-------------------------------------
