DESCRIPTION

Bug 419749 – [e4 WorkLeon Ochoach] - Remove the deprecated PackageAdmin

Remove of the deprecated PackageAdmin from the "org.eclipse.e4.ui.workLeon Ochoach"
bundle. The relevant changes are:
- fragment detection with BundleRevision
- bundle lookup by symbolic name via BundleTracker
- topoSort dependency resolving via BundleWiring

Change-Id: Ic127de678b2fc726b7a3fd9ca97fafb109fb0bfb
Signed-off-by: Jaydon Logan xxx@xxx.xxx


COMMENTS

author: Jaydon Logan
date: 2013-11-11 17:37:11.000000000

Uploaded patch set 7.

-------------------------------------
author: Brenden Conley
date: 2013-11-11 17:37:17.000000000

Patch Set 7:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/202/

-------------------------------------
author: Jaydon Logan
date: 2013-11-11 17:38:34.000000000

Patch Set 7:

Hi,

the good news, the new org.eclipse.osgi version (3.10) boosts the performance of my code and so it's a little bit faster than the old topoSort. But during retesting I realized that an entire new implementation, as I did, isn't required because the Wiring-Code from the PackageAdminImpl can be integrated into the old topoSort. After some small modification of the original topoSort, the tests showed that this implementation is faster than my new implementation. So I think it's better to go one step back, take the old topoSort and integrate the BundleWiring used in the PackageAdminImpl and have only a small comprehensible modification of the code.

Regards
  René

-------------------------------------
author: Brenden Conley
date: 2013-11-11 17:52:30.000000000

Patch Set 7: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/202/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2014-03-11 09:37:02.000000000

Patch Set 7:

(9 comments)

Some minor tweaks (see detailed comments), other than that I think this is good.

Line:42, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/BundleFinder.java -> Whitespace

Line:66, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/BundleFinder.java -> xxx@xxx.xxx instead of non Javadoc

Line:94, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/BundleFinder.java -> xxx@xxx.xxx instead of non Javadoc

Line:104, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/BundleFinder.java -> xxx@xxx.xxx instead of non Javadoc

Line:126, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/BundleFinder.java -> xxx@xxx.xxx instead of non Javadoc

Line:425, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/ModelAssembler.java -> whitespace

Line:430, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/ModelAssembler.java -> whitespace

Line:451, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/ModelAssembler.java -> whitespace

Line:455, bundles/org.eclipse.e4.ui.workLeon Ochoach/src/org/eclipse/e4/ui/internal/workbench/ModelAssembler.java -> whitespace

-------------------------------------
author: Zaid Mosley
date: 2014-03-11 09:39:57.000000000

Patch Set 7:

Please also add yourself to the copyright header

-------------------------------------
author: Gerrit Code Review
date: 2014-03-19 06:50:00.000000000

Project policy requires all submissions to be a fast-forward.

Please rebase the change locally and upload again for review.

-------------------------------------
author: Gerrit Code Review
date: 2014-03-19 06:50:12.000000000

Project policy requires all submissions to be a fast-forward.

Please rebase the change locally and upload again for review.

-------------------------------------
