DESCRIPTION

Bug 107436 - [IDE] navigator: show file/folder in "Windows Explorer",
Finder, Nautilus

Use a platform dependent command to open the external file explorer


Signed-off-by: Elisha Ray xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-09-24 14:04:28.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/34/

-------------------------------------
author: Brenden Conley
date: 2013-09-24 14:16:43.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/34/ : SUCCESS

-------------------------------------
author: Slade Moran
date: 2013-09-24 14:23:50.000000000

Patch Set 1:

(8 comments)

Line:198, bundles/org.eclipse.ui.ide/plugin.properties -> The name should be: Show In (System Explorer)

Line:62, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/handlers/ShowInSystemExplorerHandler.java -> You need to use the adapt to check if the selection is an IResource.  You can use org.eclipse.ui.internal.util.Util.getAdapter(Object, Class)

Line:67, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/handlers/ShowInSystemExplorerHandler.java -> You need to handle a null coming back for the IResource path.

Line:88, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/handlers/ShowInSystemExplorerHandler.java -> You should use event.getCommand().getName() in your log messages.

Line:124, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/handlers/ShowInSystemExplorerHandler.java -> getLocation() can return null (for example, it's a resource on a remote file system).  You have to prepare to return null from this method.

Line:126, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEInternalPreferences.java -> "SYSTEM EXPLORER" should have an '_' in it: "SYSTEM_EXPLORER"

Line:2047, bundles/org.eclipse.ui.ide/plugin.xml -> You don't need the label attribute here, it will be picked up automatically from the command Name.

Line:2238, bundles/org.eclipse.ui.ide/plugin.xml -> The with element can contain ANDs its contained elements.  So you can probably reduce this to:
<with variable="selection">
  <count value="1"/>
  <iterate ifEmpty="false">
    <adapt type="org.eclipse.core.resources.IResource"/>
  </iterate>
</with>

-------------------------------------
