DESCRIPTION

Bug 416166 - Contact demo update to use the model service for object
creation and simplification 

Change-Id: I5ac85773938e5be95f1aad900add47b5cad00a3a
Signed-off-by: Zaid Mosley xxx@xxx.xxx

COMMENTS

author: Slade Moran
date: 2013-09-12 20:38:48.000000000

Patch Set 2: Code-Review-1

(2 comments)

comments about the 2 theme processors inline.

Line:66, examples/org.eclipse.e4.demo.contacts/src/org/eclipse/e4/demo/contacts/processors/MenuThemeProcessor.java -> This code looks duplicated in both classes.  Should it be in the Util class?

Line:78, examples/org.eclipse.e4.demo.contacts/src/org/eclipse/e4/demo/contacts/processors/MenuThemeProcessor.java -> Isn't this a candidate for EMenuService.createModelElement(*)?

-------------------------------------
author: Gerrit Code Review
date: 2013-11-14 21:56:59.000000000

Project policy requires all submissions to be a fast-forward.

Please rebase the change locally and upload again for review.

-------------------------------------
author: Gerrit Code Review
date: 2013-11-14 22:14:05.000000000

Project policy requires all submissions to be a fast-forward.

Please rebase the change locally and upload again for review.

-------------------------------------
