DESCRIPTION

Bug 414741 - ToolbarControl in own ToolBar throws NPE

Set default contribution cureSide to SWT.TOP

Change-Id: Ie6728bf14bb7ece05d68c8e904760d29bfcf9181
Signed-off-by: DME xxx@xxx.xxx


COMMENTS

author: Slade Moran
date: 2013-08-13 11:47:22.000000000

Uploaded patch set 4.

-------------------------------------
author: Slade Moran
date: 2013-08-13 11:51:24.000000000

Patch Set 4: Code-Review-1

(2 comments)

2 comments in the review.  To update this fix:

1) check out patch set 4
2) make the changes necessary for the review
3) amend the commit to include your changes
4) push again to the Gerrit review system

It will create a patch set 5.

Line:66, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/menus/CompatibilityWorkbenchWindowControlContribution.java -> Missing the parent != null check

Line:84, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/menus/CompatibilityWorkbenchWindowControlContribution.java -> If you've already set TOP, I'd skip this last case statement.

-------------------------------------
